Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC-2494 compliant BabyJubJub #926

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vasemkin
Copy link

@vasemkin vasemkin commented Feb 2, 2025

Description

This PR builds upon the work by @Shigoto-dev19 in the archived arkworks-rs/curves repository. Please see the relevant discussions.

  • Added a Circom compatible Baby Jubjub elliptic curve according to ERC-2494
    • The literature test cases are verified(not explicitly added in order to respect the architecture!).
    • The architecture is kept the same as the other Twisted Edwards curves by arkworks-rs/curves.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@vasemkin vasemkin requested review from a team as code owners February 2, 2025 07:21
@vasemkin vasemkin requested review from Pratyush, weikengchen and tyshko-rostyslav and removed request for a team February 2, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants