feat: allow trailing zeros & only specifying decimal component when using string.numeric.parse #1220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for trailing zeros when using
string.numeric.parse
, such that e.g.type("string.numeric.parse")("3.00")
andtype("string.numeric.parse")(".5")
works.Why
Stemmed from conversation with @ssalbdivad on Discord here.
How
Add new
numericStringMatcher
regex, which has the same restrictions as the pre-existingwellFormedNumberMatcher
bar the trailing zeros, and update thestring.numeric.parse
keyword to use it instead ofwellFormedNumberMatcher
.Here's the regex change to allow trailing zeros:
Test
then within the node repl: