-
-
Notifications
You must be signed in to change notification settings - Fork 96
Change Child#key type from Any to String and promote it to stable #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+561
−319
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 29 additions & 11 deletions
40
decompose/src/commonMain/kotlin/com/arkivanov/decompose/Child.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,64 @@ | ||
| package com.arkivanov.decompose | ||
|
|
||
| /** | ||
| * A holder class for child [configuration], [instance] and [key]. | ||
| */ | ||
| sealed class Child<out C : Any, out T : Any> { | ||
|
|
||
| /** | ||
| * A configuration object the child was originally created with. | ||
| */ | ||
| abstract val configuration: C | ||
|
|
||
| /** | ||
| * The actual child instance. | ||
| */ | ||
| abstract val instance: T? | ||
|
|
||
| @ExperimentalDecomposeApi | ||
| abstract val key: Any | ||
| /** | ||
| * A key of the child, unique within the navigation model managing the child. | ||
| */ | ||
| abstract val key: String | ||
|
|
||
| data class Created<out C : Any, out T : Any> @ExperimentalDecomposeApi constructor( | ||
| data class Created<out C : Any, out T : Any>( | ||
| override val configuration: C, | ||
| override val instance: T, | ||
|
|
||
| @property:ExperimentalDecomposeApi | ||
| override val key: Any, | ||
| override val key: String, | ||
| ) : Child<C, T>() { | ||
| // TODO: Annotate with @VisibleForTesting in version 4.0 | ||
| constructor(configuration: C, instance: T) : this( | ||
| configuration = configuration, | ||
| instance = instance, | ||
| key = configuration, | ||
| key = configuration.hashString(), | ||
| ) | ||
|
|
||
| @Deprecated(message = "For binary compatibility", level = DeprecationLevel.HIDDEN) | ||
| fun copy(configuration: @UnsafeVariance C, instance: @UnsafeVariance T): Child<C, T> = | ||
| copy(configuration = configuration, instance = instance) | ||
|
|
||
| @Deprecated(message = "For binary compatibility", level = DeprecationLevel.HIDDEN) | ||
| fun copy(configuration: @UnsafeVariance C, instance: @UnsafeVariance T, key: Any): Created<C, T> = | ||
| copy(configuration = configuration, instance = instance, key = key.toString()) | ||
| } | ||
|
|
||
| data class Destroyed<out C : Any> @ExperimentalDecomposeApi constructor( | ||
| override val configuration: C, | ||
|
|
||
| @property:ExperimentalDecomposeApi | ||
| override val key: Any, | ||
| override val key: String, | ||
| ) : Child<C, Nothing>() { | ||
| // TODO: Annotate with @VisibleForTesting in version 4.0 | ||
| constructor(configuration: C) : this( | ||
| configuration = configuration, | ||
| key = configuration, | ||
| key = configuration.hashString(), | ||
| ) | ||
|
|
||
| override val instance: Nothing? = null | ||
|
|
||
| @Deprecated(message = "For binary compatibility", level = DeprecationLevel.HIDDEN) | ||
| fun copy(configuration: @UnsafeVariance C): Child<C, Nothing> = | ||
| copy(configuration = configuration) | ||
|
|
||
| @Deprecated(message = "For binary compatibility", level = DeprecationLevel.HIDDEN) | ||
| fun copy(configuration: @UnsafeVariance C, key: Any): Destroyed<C> = | ||
| copy(configuration = configuration, key = key.toString()) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.