fix(map_priority) : priority starts from 1 and not from 0

django/common/scripts/cleaning/map_priority.py

@@ -9,14 +9,15 @@ class Priority(Enum):
 
 
 def map_priority(raw_input):
-    """Map int to ServiceRequest.priority (0: stat, 1: asap, 2: urgent, 3+ routine)"""
+    """Map int to ServiceRequest.priority (1: stat, 2: asap, 3: urgent, else: routine)"""
     mapping = {
-        "0": Priority.STAT.value,
-        "1": Priority.ASAP.value,
-        "2": Priority.URGENT.value,
-        "3": Priority.ROUTINE.value,
+        "1": Priority.STAT.value,
+        "2": Priority.ASAP.value,
+        "3": Priority.URGENT.value,
+        "4": Priority.ROUTINE.value,
     }
-    if str(raw_input) in mapping.keys():
+    try:
         return mapping[str(raw_input)]
-    else:
-        return mapping["3"]
+    except KeyError:
+        # if the code is unknown, use "ROUTINE" as default value
+        return Priority.ROUTINE.value

tests/common/scripts/cleaning/test_map_priority.py

@@ -5,27 +5,27 @@ def test_map_priority():
 
     raw_input_1 = "0"
     output_1 = map_priority(raw_input_1)
-    assert output_1 == "stat"
+    assert output_1 == "routine"
 
     raw_input_2 = 0
     output_2 = map_priority(raw_input_2)
-    assert output_2 == "stat"
+    assert output_2 == "routine"
 
     raw_input_3 = "1"
     output_3 = map_priority(raw_input_3)
-    assert output_3 == "asap"
+    assert output_3 == "stat"
 
     raw_input_4 = 1
     output_4 = map_priority(raw_input_4)
-    assert output_4 == "asap"
+    assert output_4 == "stat"
 
     raw_input_5 = "2"
     output_5 = map_priority(raw_input_5)
-    assert output_5 == "urgent"
+    assert output_5 == "asap"
 
     raw_input_6 = 2
     output_6 = map_priority(raw_input_6)
-    assert output_6 == "urgent"
+    assert output_6 == "asap"
 
     raw_input_7 = "50"
     output_7 = map_priority(raw_input_7)
@@ -42,3 +42,11 @@ def test_map_priority():
     raw_input_10 = -1
     output_10 = map_priority(raw_input_10)
     assert output_10 == "routine"
+
+    raw_input_11 = "3"
+    output_11 = map_priority(raw_input_11)
+    assert output_11 == "urgent"
+
+    raw_input_12 = 3
+    output_12 = map_priority(raw_input_12)
+    assert output_12 == "urgent"