Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update attribute descriptions #8

Merged
merged 53 commits into from
May 27, 2021
Merged

Update attribute descriptions #8

merged 53 commits into from
May 27, 2021

Conversation

nriss
Copy link
Contributor

@nriss nriss commented Apr 28, 2021

Fixes

Fixes #4

Description

Add description to mustSupport attributes to indicate in which situation data are used

Technical details

Tests

@nriss nriss requested a review from BPierrick April 29, 2021 11:55
BPierrick
BPierrick reviewed May 4, 2021
View reviewed changes
input/pagecontent/index.xml Outdated
Comment on lines 16 to 32
<ul>
<li>Resources used by Cohort360:
<a href="StructureDefinition-cohort-condition.html">CohortCondition</a>,
<a href="StructureDefinition-cohort-document.html">CohortDocument</a>,
<a href="StructureDefinition-cohort-encounter.html">CohortEncounter</a>,
<a href="StructureDefinition-cohort-group.html">CohortGroup</a>,
<a href="StructureDefinition-cohort-observation.html">CohortObservation</a>,
<a href="StructureDefinition-cohort-organization.html">CohortOrganization</a>,
<a href="StructureDefinition-cohort-patient.html">CohortPatient</a>,
<a href="StructureDefinition-cohort-practitioner.html">CohortPractitioner</a>,
<a href="StructureDefinition-cohort-procedure.html">CohortProcedure</a> and
<a href="StructureDefinition-cohort-ghm.html">GHM</a>
</li>
<li>Resources created by Cohort360 and the DPO portail:
<a href="StructureDefinition-practitioner-consent.html">PractitionerConsent</a> and
<a href="StructureDefinition-refused-research-consent.html">RefusedResearchConsent</a>
</li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal that PractitionerRole is missing from this list ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can find it line 30, PractitionerConsent which is a profile derived from PractitionerRole !

@nriss nriss changed the title [WIP] Update attribute descriptions Update attribute descriptions May 4, 2021
@nriss nriss requested a review from elsiehoffet-94 May 4, 2021 15:43
@nriss nriss changed the title Update attribute descriptions [WIP] Update attribute descriptions May 4, 2021
@nriss nriss changed the title [WIP] Update attribute descriptions Update attribute descriptions May 4, 2021
elsiehoffet-94
elsiehoffet-94 suggested changes May 6, 2021
View reviewed changes
Copy link

@elsiehoffet-94 elsiehoffet-94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have a few comments :

  • Why are there some descriptions in French and not all in English ? For specific acronyms (like GHM) we could have a dedicated vocab note somewhere in the IG :)

  • Could you also specify which types of Observations are used currently, and recommended ?

  • Regarding the PMSI, I think it could be interesting to document the data required (ICD-10 terminology, types of resources involved etc)
    @Peltier10 you can check this out before we deploy cohort

@nriss nriss requested a review from Peltier10 May 6, 2021 16:26
@nriss
Copy link
Contributor Author

nriss commented May 7, 2021 •
edited
Loading

  • recommended

Thanks for your review 💯

  • The Observation usage is not well defined for now, I will plan a call with Sophie to see what we can do. (This part must be hospital-dependent I think)
  • I'm going to make further investigation for the PMSI in another pr Create profiles & VS for PMSI #9

nriss added 23 commits May 26, 2021 19:14
@nriss
update package-list & sushi-config files
3688bad
@nriss
add cohort360 logo & update index
75a647b
@nriss
update examples and ig.ini
d09e616
@nriss
update gitignore
d9461ee
@nriss
updating gitignore again and removing input-cache from git
060fe67
@nriss
updating profile names to be consistent and adding some attribute des…
1e9589f 
…cr to MS attr
@nriss
use arkhn template
c249826
@nriss
adding lots of description
b0772f7
@nriss
finalizing the addition of MS definitions
6fc8c90
@nriss
even more addition of MS definitions
8d824de
@nriss
even more addition of MS definitions
cf60cbd
@nriss
fix typos on sushi files
ffefbb2
@nriss
update template link
294e8ac
@nriss
improving descr and unifying them to english
9997e30
@nriss
changing id & homepage
a89bc5c
@nriss
add GHM vs
cc12e80
@nriss
add ghm vs
00ee998
@nriss
removing - from name
1b452bf
@nriss
add download page
e927fae
@nriss
correct title & descr inversion on Patient
c20b771
@nriss
remove useless used by cohort 360 app
ae6f7e2
@nriss
update artifact summary using categories
216fa57
@nriss
fixing merge #1
b5ea2d8
@nriss
Copy link
Contributor Author

nriss commented May 27, 2021

Lgtm !
Some comments, to convert into issues, maybe?

  • why Cohort Document and not documentReference ?

Renamed in Cohort Document Reference

  • I see you added the extension for raw text for the use case of TLS , can we also include the composition Resource ? Is it relevant?

Under discussion with @Peltier10 !

  • in Artifacts summary > Created Resources, you kept specifying "used by Cohort360" in the first two resources

Removed!

  • I think you can rename the PractitionerRoleone examples with a more significant name (currently it's an id)

Done! For information, it is automatically the id that is shown, I just renamed the id permission-example

@nriss nriss merged commit c4b921e into main May 27, 2021
@nriss nriss deleted the nr/addDefToMustSupport branch May 27, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BPierrick BPierrick BPierrick left review comments

@elsiehoffet-94 elsiehoffet-94 elsiehoffet-94 approved these changes

@Peltier10 Peltier10 Awaiting requested review from Peltier10

@tevariou tevariou Awaiting requested review from tevariou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add descr to mustSupport attributes
3 participants
@nriss @BPierrick @elsiehoffet-94