Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unresolved externs for rpi 32 build #704

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ntc490
Copy link

@ntc490 ntc490 commented Jan 7, 2024

Got btop building on my RPi 3B+ running Raspian Lite 32.

@imwints
Copy link
Contributor

imwints commented Jan 7, 2024

Just out of curiosity, are you using the latest version of raspbian? And, are you building with or without GPU support?

Moving the dl library to a LINUX && BTOP_GPU section so -ldl doesn't
get included for non-Linux or non-GPU builds
@ntc490
Copy link
Author

ntc490 commented Jan 7, 2024 via email

@imwints
Copy link
Contributor

imwints commented Jan 8, 2024

The big thanks should go to @aristocratos, not myself.

The actual minimum version should be 3.25 because of the LINUX and APPLE variables introduced a couple of weeks ago

Regarding the requirement of libdl:
Since glibc-2.34 linking with -dl is not explicitly required anymore

In order to support smoother in-place-upgrades and to simplify
the implementation of the runtime all functionality formerly
implemented in the libraries libpthread, libdl, libutil, libanl has
been integrated into libc. New applications do not need to link with
-lpthread, -ldl, -lutil, -lanl anymore. [...]

You probably need to do some updates. From my RaspberryPi 4:

$ cat /etc/os-release | head -1 && dpkg -s libc-bin | grep Version && cmake --version | head -1

PRETTY_NAME="Debian GNU/Linux 12 (bookworm)" # Raspian
Version: 2.36-9+rpt2+deb12u3 # glibc
cmake version 3.25.1 # CMake

Also, you most likely should not use a 32-bit version of any distribution nowadays if your CPU supports 64-bit, which the Pi3 does.

@ntc490
Copy link
Author

ntc490 commented Jan 8, 2024 via email

@ntc490
Copy link
Author

ntc490 commented Jan 8, 2024 via email

@imwints
Copy link
Contributor

imwints commented Jan 8, 2024

In the worst case there are still the static release binaries or Docker + alpine where you can build the static binary yourself.

Since the Makefile doesn't do it I wouldn't like to do this to support (compiling against) some ancient glibc.
Being written with C++-20 btop is dependent on recent compilers anyway so it wouldn't make much sense to support (compiling against) older libc's while requiring new compilers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants