Open
Conversation
…ssiondatatakeid added function to convert timestamp string to datetime obj to compare scihub acq to existing acq copied deprecate_document function to that we can deprecate the older acq fixed some python formatting added .gitignore file added some logging to my de-duplication logic
NamrataM
reviewed
Jun 5, 2019
| acq_id = item['_source']['metadata'].get('id') | ||
| ingestion_date = item['_source']['metadata'].get('ingestiondate') | ||
| mission_data_id_store[missiondatatakeid] = { | ||
| 'id': acq_id, |
Collaborator
There was a problem hiding this comment.
Looking through the usage of the mission_data_id_store, I don't see the "id" field being utilized anywhere. @DustinKLo Could you verify that? If it's not being used then please delete it from the dict.
Contributor
Author
There was a problem hiding this comment.
@NamrataM yes, we save it in the metadata field, i use it so i can remove id's from prods_missing if scihub's acquisition is older than ours
Collaborator
There was a problem hiding this comment.
@DustinKLo Okay great, thanks for that. I need to revisit the logic of duplicate detection then. May need to add a few more constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logic that compares scihub acq with existing acq by missiondatatakeid
added function to convert timestamp string to datetime obj to compare scihub acq to existing acq
copied deprecate_document function to that we can deprecate the older acq
fixed some python formatting
added .gitignore file
added some logging to my de-duplication logic