code refactoring... but questions remain #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overwrote a reference. fixed the problem
…use i overwrote a reference. fixed the problem
…bugs i introduced...
|
Hey, I'm not sure what questions remain for you, but I created my own fork of the repository and tried to explain what I think what the thought process was that Austin had while writing the code. I also did some refactoring of my own which might help you out if you are looking for more alternative ways to lay out the code to promote readability and extensibility and general good form. |
Author
|
@5mattmatt1 thanks a lot for your effort. I am not sure my self what I meant yesterday. I must admit I did this after coming backing from the Biergarten XD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i refactored your code a little, but i am not totally sure what you are doing. at least partially. tomorrow morning with some coffee i will screen your code again to actually try to understand it ^^ but looks like a lot of fun :D