Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve StatefulSet immutable field error messages #654

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aali309
Copy link

@aali309 aali309 commented Dec 17, 2024

Fixes: 20899
Depends on: 21209

Before:
Screenshot 2024-12-13 at 8 30 35 PM

After:
Screenshot 2024-12-18 at 2 31 48 PM

@aali309 aali309 changed the title feat: Enhance sync error message to report the actual field(s) that violated forbidden updates feat: improve StatefulSet immutable field error messages Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 16 lines in your changes missing coverage. Please review.

Project coverage is 54.97%. Comparing base (8849c3f) to head (ffd6fbb).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/sync/sync_context.go 85.71% 11 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   54.26%   54.97%   +0.70%     
==========================================
  Files          64       64              
  Lines        6164     6381     +217     
==========================================
+ Hits         3345     3508     +163     
- Misses       2549     2594      +45     
- Partials      270      279       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aali309 aali309 force-pushed the reportTheFieldThatViolated branch from 0ede6a9 to ffd6fbb Compare December 18, 2024 19:29
@aali309 aali309 marked this pull request as ready for review December 18, 2024 19:33
@aali309 aali309 requested a review from a team as a code owner December 18, 2024 19:33
@aali309 aali309 force-pushed the reportTheFieldThatViolated branch 2 times, most recently from aa740d4 to ffd6fbb Compare December 19, 2024 20:32
feat: enhance StatefulSet immutable field error message to show specific field changes

Signed-off-by: Atif Ali <[email protected]>

formatting && added tests

Signed-off-by: Atif Ali <[email protected]>
@aali309 aali309 force-pushed the reportTheFieldThatViolated branch from ffd6fbb to 1751d55 Compare December 19, 2024 20:49
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report the field that violated the updates to fields are forbidden constraint
1 participant