feat: return images from resources when sync occurs #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Hoffman <[email protected]>
Aaron-9900
force-pushed
the
feat/add-images-to-resources
branch
from
922aecd to
3f1734a
Compare
Aaron-9900
changed the title
Signed-off-by: Aaron Hoffman <[email protected]>
andrii-korotkov-verkada
approved these changes
Nov 27, 2024
Signed-off-by: Aaron Hoffman <[email protected]>
Aaron-9900
force-pushed
the
feat/add-images-to-resources
branch
from
5281e57 to
ae4000b
Compare
Signed-off-by: Aaron Hoffman <[email protected]>
andrea-mosk
reviewed
Nov 27, 2024
pkg/utils/kube/kube.go
Outdated
| for _, container := range containers { | ||
| containerMap, ok := container.(map[string]interface{}) | ||
| if !ok { | ||
| return nil |
There was a problem hiding this comment.
Should we continue instead of returning here? It might be something related to the single container only
There was a problem hiding this comment.
Makes sense to extract as much data as possible. Added continue on 5b2c46f but maybe @andrii-korotkov-verkada has a different take
| @@ -404,6 +404,34 @@ func GetDeploymentReplicas(u *unstructured.Unstructured) *int64 { | |||
| return &val | |||
| } | |||
|
|
|||
| func GetResourceImages(u *unstructured.Unstructured) []string { | |||
There was a problem hiding this comment.
For CronJobs it seems that the image is under spec.jobTemplate.spec.template.spec.containers. Should we also check there?
…for cronjobs Signed-off-by: Aaron Hoffman <[email protected]>
Signed-off-by: Aaron Hoffman <[email protected]>
andrea-mosk
approved these changes
Nov 27, 2024
Signed-off-by: Aaron Hoffman <[email protected]>
Signed-off-by: Aaron Hoffman <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the Gitops side of this issue: argoproj/argo-cd#20896
Adds an api to
kube.goto get the images from a resource. Adds those images toResourceSyncResult