chore(deps): upgrade go version in dockerfile #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] fix warnings about case of `as` to `AS` in Dockerfile - `FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)` - [x] shorten go version in go.mod - [x] update Dockerfile Go version from 1.17 to 1.22 to match go.mod - [x] upgrade alipine/git image version to latest, current was 4 years old - -from alpine/git:v2.24.3 (4 years old) to alpine/git:v2.45.2 - [x] fix warning with linting - `WARN [config_reader] The configuration option 'run.skip-files' is deprecated, please use 'issues.exclude-files'` - [x] add .tool-versions (asdf) to .gitignore Signed-off-by: jmeridth <[email protected]>
|
|
Merging #639 first will fix the tar errors in the CI run with these changes (bottom of page). |
jmeridth
requested review from
crenshaw-dev,
pasha-codefresh and
ishitasequeira
|
Going to create argo-cd draft PR that uses these changes. Especially to test the git version update (2.24.3 -> 2.45.2) |
Can you link the draft PR so we can see the argo-cd build passing? |
jmeridth
added a commit
to jmeridth/argo-cd
that referenced
this pull request
Nov 26, 2024
Uses changes from argoproj/gitops-engine#638 Signed-off-by: jmeridth <[email protected]>
14 tasks
crenshaw-dev
approved these changes
Nov 26, 2024
14 tasks
jmeridth
added a commit
to jmeridth/argo-cd
that referenced
this pull request
Dec 4, 2024
Related to argoproj/gitops-engine#638 Signed-off-by: jmeridth <[email protected]>
crenshaw-dev
pushed a commit
to argoproj/argo-cd
that referenced
this pull request
Dec 5, 2024
Related to argoproj/gitops-engine#638 Signed-off-by: jmeridth <[email protected]>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
Related to argoproj/gitops-engine#638 Signed-off-by: jmeridth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I noticed the version difference between the go.mod and Dockerfile in the repo (1.17 vs 1.22). Fixed a few other things also, like upgrading the version of the alpine/git image to the latest version.
astoASin DockerfileFromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)WARN [config_reader] The configuration option 'run.skip-files' is deprecated, please use 'issues.exclude-files'Tests
Test pass locally. No new features really added so unsure if new tests are needed.
Questions
Do I need to run this against an argo-cd instance or with argo-cd test suite to ensure we're good?