Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address kubectl auth reconcile during server-side diff #562

Merged
merged 9 commits into from
Jan 22, 2024

Conversation

leoluz
Copy link
Contributor

@leoluz leoluz commented Jan 12, 2024

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (aba3819) 54.47% compared to head (2d078b1) 54.41%.

❗ Current head 2d078b1 differs from pull request most recent head 50a2ebc. Consider uploading reports for the commit 50a2ebc to get more accurate results

Files Patch % Lines
pkg/utils/kube/resource_ops.go 0.00% 24 Missing ⚠️
pkg/diff/diff.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   54.47%   54.41%   -0.06%     
==========================================
  Files          41       41              
  Lines        4793     4798       +5     
==========================================
  Hits         2611     2611              
- Misses       1969     1974       +5     
  Partials      213      213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
pkg/utils/kube/resource_ops.go Outdated Show resolved Hide resolved
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
2.9% Duplication on New Code

See analysis details on SonarCloud

@crenshaw-dev crenshaw-dev merged commit c1e2359 into argoproj:master Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppController: error calculating server side diff with 2.10-rc1
2 participants