Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log cluster sync error #541

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

crenshaw-dev
Copy link
Member

Right now we only pass this up to the caller to log. That has two downsides:

  1. The caller may not log it (there's at least one such case in Argo CD)
  2. The caller may log it too often, producing duplicate log lines and making it difficult to determine exactly how many clusters are "sick" - for example, Argo CD logs this error for every single Application deployed to the sick cluster

Signed-off-by: Michael Crenshaw <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b0fffe4) 54.61% compared to head (4d728d6) 54.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
- Coverage   54.61%   54.60%   -0.02%     
==========================================
  Files          41       41              
  Lines        4640     4641       +1     
==========================================
  Hits         2534     2534              
- Misses       1910     1911       +1     
  Partials      196      196              
Files Coverage Δ
pkg/cache/cluster.go 49.28% <0.00%> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit a00ce82 into argoproj:master Sep 29, 2023
@crenshaw-dev crenshaw-dev deleted the log-cluster-sync-failure branch September 29, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants