feat: Implement Server-Side Diffs #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
leoluz
force-pushed
the
server-side-diff
branch
from
dc03df9 to
aed8301
Compare
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
leoluz
force-pushed
the
server-side-diff
branch
from
aed8301 to
e1754b3
Compare
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #522 +/- ##
==========================================
- Coverage 54.70% 54.47% -0.23%
==========================================
Files 41 41
Lines 4645 4793 +148
==========================================
+ Hits 2541 2611 +70
- Misses 1908 1969 +61
- Partials 196 213 +17 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
crenshaw-dev
requested changes
Dec 7, 2023
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
fix query param verifier instantiation
Signed-off-by: Leonardo Luz Almeida <[email protected]>
|
crenshaw-dev
approved these changes
Dec 18, 2023
| return result, nil | ||
| } | ||
|
|
||
| // ServerSideDiff will execute a k8s server-side apply in dry-run mode with the |
There was a problem hiding this comment.
Suggested change
| // ServerSideDiff will execute a k8s server-side apply in dry-run mode with the | |
| // serverSideDiff will execute a k8s server-side apply in dry-run mode with the |
anandf
added a commit
to anandf/gitops-engine
that referenced
this pull request
Jan 13, 2024
This reverts commit aba3819.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Server-Side Diffs
fix argoproj/argo-cd#11574