Improve cognitive complexity of diff.NormalizeSecret

pkg/diff/diff.go

@@ -697,16 +697,7 @@ func NormalizeSecret(un *unstructured.Unstructured) error {
 		return nil
 	}
 	if stringData, found, err := unstructured.NestedMap(un.Object, "stringData"); found && err == nil {
-		for k, v := range stringData {
-			switch v := v.(type) {
-			case int64:
-				stringData[k] = toString(v)
-			}
-		}
-		err := unstructured.SetNestedField(un.Object, stringData, "stringData")
-		if err != nil {
-			return fmt.Errorf("unstructured.SetNestedField error: %s", err)
-		}
+		stringifyNestedIntKeys(un, stringData)
 	}
 	var secret corev1.Secret
 	err := runtime.DefaultUnstructuredConverter.FromUnstructured(un.Object, &secret)
@@ -965,3 +956,18 @@ func remarshal(obj *unstructured.Unstructured, o options) *unstructured.Unstruct
 	unstrBody = jsonutil.RemoveMapFields(obj.Object, unstrBody)
 	return &unstructured.Unstructured{Object: unstrBody}
 }
+
+func stringifyNestedIntKeys(un *unstructured.Unstructured, stringData map[string]interface{}) error {
+	for k, v := range stringData {
+		switch v := v.(type) {
+		case int64:
+			stringData[k] = toString(v)
+		}
+	}
+	err := unstructured.SetNestedField(un.Object, stringData, "stringData")
+	if err != nil {
+		return fmt.Errorf("unstructured.SetNestedField error: %s", err)
+	} else {
+		return nil
+	}
+}