Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-workflows): suggest non deprecated option #3113

Merged
merged 3 commits into from
Feb 15, 2025
Merged

chore(argo-workflows): suggest non deprecated option #3113

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0421bf
chore: suggest non deprecated option
chansuke Jan 9, 2025
27ded1e
Merge branch 'main' into fix/suggest-authmodes
yu-croco Feb 15, 2025
51541e4
Update Chart.yaml
yu-croco Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: suggest non deprecated option 
Signed-off-by: chansuke <chansuke0@gmail.com>
  • Loading branch information
@chansuke
chansuke committed Jan 14, 2025
commit a0421bffabe2e40a9d967ec9f12780e21c6bd8cb
3 changes: 3 additions & 0 deletions charts/argo-workflows/Chart.yaml
View file
Original file line number Diff line number Diff line change
@@ -18,3 +18,6 @@ annotations:
artifacthub.io/changes: |
- kind: added
description: Support configuring workflow events in the controller
artifacthub.io/changes: |
- kind: fixed
description: Update the SSO configuration instructions to reflect the correct field name
2 changes: 1 addition & 1 deletion charts/argo-workflows/README.md
View file
Original file line number Diff line number Diff line change
@@ -344,7 +344,7 @@ Fields to note:
| server.sso.clientSecret.key | string | `"client-secret"` | Key of a secret to retrieve the app OIDC client secret |
| server.sso.clientSecret.name | string | `"argo-server-sso"` | Name of a secret to retrieve the app OIDC client secret |
| server.sso.customGroupClaimName | string | `""` | Override claim name for OIDC groups |
| server.sso.enabled | bool | `false` | Create SSO configuration. If you set `true` , please also set `.Values.server.authMode` as `sso`. |
| server.sso.enabled | bool | `false` | Create SSO configuration. If you set `true` , please also set `.Values.server.authModes` as `sso`. |
| server.sso.filterGroupsRegex | list | `[]` | Filter the groups returned by the OIDC provider |
| server.sso.insecureSkipVerify | bool | `false` | Skip TLS verification for the HTTP client |
| server.sso.issuer | string | `"https://accounts.google.com"` | The root URL of the OIDC identity provider |
2 changes: 1 addition & 1 deletion charts/argo-workflows/values.yaml
View file
Original file line number Diff line number Diff line change
@@ -717,7 +717,7 @@ server:

# SSO configuration when SSO is specified as a server auth mode.
sso:
# -- Create SSO configuration. If you set `true` , please also set `.Values.server.authMode` as `sso`.
# -- Create SSO configuration. If you set `true` , please also set `.Values.server.authModes` as `sso`.
Copy link
Collaborator

@yu-croco yu-croco Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to handle below to update README, by running ./scripts/helm-docs.sh (instruction is in the link below).
Ref:

I have updated the documentation according to documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I hit the command but the generation was falling because of this problem. Fixed and generated now.

enabled: false
# -- The root URL of the OIDC identity provider
issuer: https://accounts.google.com
Loading