Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-cd): Update public.ecr.aws/docker/library/redis Docker tag to v7.4.2 #3108

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

argoproj-renovate[bot]
Copy link
Contributor

This PR contains the following updates:

Package Update Change
public.ecr.aws/docker/library/redis (source) patch 7.4.1-alpine -> 7.4.2-alpine

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@argoproj-renovate argoproj-renovate bot force-pushed the renovate/public.ecr.aws-docker-library-redis-7.x branch 6 times, most recently from f956f6b to c0addfd Compare January 11, 2025 11:12
@argoproj-renovate argoproj-renovate bot force-pushed the renovate/public.ecr.aws-docker-library-redis-7.x branch 3 times, most recently from dadbd89 to cfdb3f1 Compare January 20, 2025 08:21
@argoproj-renovate argoproj-renovate bot force-pushed the renovate/public.ecr.aws-docker-library-redis-7.x branch 5 times, most recently from 2cbc254 to 193918c Compare January 27, 2025 16:20
… to v7.4.2

Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
@argoproj-renovate argoproj-renovate bot force-pushed the renovate/public.ecr.aws-docker-library-redis-7.x branch from 193918c to f65e59c Compare January 28, 2025 06:22
@argoproj-renovate argoproj-renovate bot changed the title chore(deps): update public.ecr.aws/docker/library/redis docker tag to v7.4.2 chore(argo-cd): Update public.ecr.aws/docker/library/redis Docker tag to v7.4.2 Jan 28, 2025
@github-actions github-actions bot added size/S and removed size/XS labels Jan 28, 2025
version: 7.7.18
version: 7.7.20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script always used to always increment by 1 every time it’s invoked. I suspect that’s all that’s happened here. The rule always used to be “only let the renovate script run once per pr”

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can manually set the version back down and it should be fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 👀
I fixed the version. 🙋 a770219

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn. I'll try to handle this in a separate PR / issue. It is introduced by my recent Renovate improvement PR:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it has always done it. It’s just been run more than once on this PR.

It increments whatever number is on the branch rather than looking at the base branch’s value.

Signed-off-by: yu-croco <[email protected]>

Signed-off-by: Aikawa <[email protected]>
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏, thanks @yu-croco for handling the manual step

@mkilchhofer mkilchhofer merged commit d81ca4b into main Jan 28, 2025
6 checks passed
@mkilchhofer mkilchhofer deleted the renovate/public.ecr.aws-docker-library-redis-7.x branch January 28, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants