fix(github): Support redis/argocd-extension-installer to Renovate #3106
Conversation
Signed-off-by: yu-croco <[email protected]>
| @@ -97,6 +97,13 @@ | |||
| "commands": ["./scripts/renovate-bump-version.sh {{depName}}"] | |||
| } | |||
| }, | |||
| { | |||
| "matchPackagePatterns": ["argoprojlabs/argocd-extension-installer"], | |||
There was a problem hiding this comment.
ref: #3072 (comment)
"prTitle": "chore(deps): update quay.io/argoprojlabs/argocd-extension-installer docker tag to v0.0.8",
"upgrades": [
{
"datasource": "docker",
"depName": "quay.io/argoprojlabs/argocd-extension-installer",
"displayPending": "",
"fixedVersion": "v0.0.5",
"currentVersion": "v0.0.5",
"currentValue": "v0.0.5",
"newValue": "v0.0.8",
"newVersion": "v0.0.8",
"packageFile": "charts/argo-cd/values.yaml",
"updateType": "patch",
"packageName": "quay.io/argoprojlabs/argocd-extension-installer"
}
]
Signed-off-by: yu-croco <[email protected]>
renovate.json
Outdated
| @@ -99,7 +99,7 @@ | |||
| }, | |||
| { | |||
| "matchPackagePatterns": ["argoprojlabs/argocd-extension-installer"], | |||
| "commitMessagePrefix": "chore({{{replace 'argoprojlabs/' '' depName}}}):", | |||
| "commitMessagePrefix": "chore({{{replace '*' 'argo-cd' depName}}}):", | |||
There was a problem hiding this comment.
hmmm ugly but it works for now, unless other argoproj (argo-workflows, agro-events, etc.) starts using the same image tags ....? 🤔
There was a problem hiding this comment.
Did you go through this list here?
https://docs.renovatebot.com/templates/
I'd start with either parentDir or somerhing based on packageFile.
There was a problem hiding this comment.
Thank you for your review. Oh there are many convenient ones. 😮 I will fix. 🙋
There was a problem hiding this comment.
I added a commit for this. 🙏
7f74bba
Signed-off-by: yu-croco <[email protected]>
| @@ -10,7 +10,14 @@ chartName=$(echo "$depName" | sed -e "s+^argoproj/++" -e "s+^argoproj-labs/++") | |||
| echo "Changed chart name is: $chartName" | |||
There was a problem hiding this comment.
Maybe we should refactor the whole script:
- Add more input parameters
- Chart name (e.g. via
parentDir) - Dependency name
- New version of the dependency
(as a replacement ofappVersion=$(grep '^appVersion:' "${parentDir}/Chart.yaml" | awk '{print $2}'))
- Chart name (e.g. via
- Do not hardcode the line
description: Bump ${chartName} to ${appVersion}"
There was a problem hiding this comment.
Thank you for your feedback. I will try to refactor. 📝
In order to pass #3104 , I modified scripts.
Related to #3072
Checklist: