Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
Signed-off-by: Derek Brown <[email protected]>
  • Loading branch information
DerekTBrown committed Jan 13, 2025
1 parent a8a2290 commit c8b602e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
6 changes: 2 additions & 4 deletions charts/argo-rollouts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: added
description: Add lifecycle settings for controller
- kind: added
description: Add terminationGracePeriodSeconds for controller
- kind: changed
description: argo-rollouts will re-deploy if changes are made to the argo-rollouts configmap.
4 changes: 1 addition & 3 deletions charts/argo-rollouts/templates/controller/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ spec:
{{- range $key, $value := . }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{/* Add the checksum of the ConfigMap to the annotations */}}
{{/* This ensures that ConfigMap changes trigger a rolling update */}}
configmap-checksum: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
checksum/cm: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
{{- end }}
labels:
{{- include "argo-rollouts.selectorLabels" . | nindent 8 }}
Expand Down

0 comments on commit c8b602e

Please sign in to comment.