Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to Restart Apps from applications list page #21307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add ability to Restart Apps from applications list page #21307

wants to merge 1 commit into from
+112 −0

Conversation

audip
Copy link

@audip audip commented Dec 24, 2024 •
edited
Loading

Aims to add UI feature of "Restart Apps" button on application list page that has been mentioned in #21305

image

Fixes #21305

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@audip audip requested a review from a team as a code owner December 24, 2024 08:22
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 24, 2024 •
edited
Loading

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@audip audip force-pushed the feat/add-restart-button-application-list branch from e01ea3e to aea0dd2 Compare December 24, 2024 08:32
@audip audip changed the title feat: Add restart apps button on Applications List view feat: Add ability to Restart Apps from applications list page Dec 24, 2024
@audip audip mentioned this pull request Dec 25, 2024
Open
andrii-korotkov-verkada
andrii-korotkov-verkada reviewed Dec 29, 2024
View reviewed changes
ui/src/app/applications/components/applications-list/applications-list.tsx
@@ -477,6 +479,11 @@ export const ApplicationsList = (props: RouteComponentProps<{}>) => {
title: 'Refresh Apps',
iconClassName: 'fa fa-redo',
action: () => ctx.navigation.goto('.', {refreshApps: true}, {replace: true})
},
{
title: 'Restart Apps',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is confusing, can we use 'Restart Apps Pods'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: add ability to restart apps from applications list page in ArgoCD
2 participants
@audip @andrii-korotkov-verkada