-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rbac): Add rights on applicationsets for the application controller #20352
base: master
Are you sure you want to change the base?
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20352 +/- ##
==========================================
- Coverage 55.04% 55.02% -0.02%
==========================================
Files 324 324
Lines 55421 55421
==========================================
- Hits 30504 30497 -7
- Misses 22303 22308 +5
- Partials 2614 2616 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably don't want to do this: argoproj/argo-helm#2974 (comment)
Updated to clarify the namespaced mode intent in the documentation |
Signed-off-by: OpenGuidou <[email protected]>
@crenshaw-dev are you ok with the content now ? |
Upstream fix for: argoproj/argo-helm#2974
Checklist: