Skip to content

Conversation

@dkarpele
Copy link
Collaborator

@dkarpele dkarpele commented Sep 19, 2025

Prometheus metrics were successfully exported after refactoring

dkarpele@dkarpele-mac /tmp % curl --insecure --header "Authorization: Bearer ${TOKEN}" https://127.0.0.1:8443/metrics | grep argocd
argocd_image_updater_applications_watched_total The total number of applications watched by Argo CD Image Updater CR
# TYPE argocd_image_updater_applications_watched_total gauge
argocd_image_updater_applications_watched_total{image_updater_cr_name="image-updater-001",image_updater_cr_namespace="argocd-image-updater-system"} 1
# HELP argocd_image_updater_k8s_api_errors_total The total number of K8S API requests resulting in error
# TYPE argocd_image_updater_k8s_api_errors_total counter
argocd_image_updater_k8s_api_errors_total 0
# HELP argocd_image_updater_k8s_api_requests_total The total number of K8S API requests performed by the Argo CD Image Updater
# TYPE argocd_image_updater_k8s_api_requests_total counter
argocd_image_updater_k8s_api_requests_total 0
  • Remove legacy flags health-port and metrics-port and replace them with health-probe-bind-address and metrics-bind-address. Update docs.
  • health module was removed in favor of controller-runtime.
  • Add RBAC rules for metrics.
  • Images metrics will be implemented in GITOPS-8068

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.57%. Comparing base (58d2b7e) to head (2d26552).

Files with missing lines Patch % Lines
cmd/run.go 33.33% 6 Missing ⚠️
cmd/common.go 0.00% 1 Missing ⚠️
pkg/webhook/server.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
+ Coverage   70.35%   70.57%   +0.21%     
==========================================
  Files          50       49       -1     
  Lines        4460     4448      -12     
==========================================
+ Hits         3138     3139       +1     
+ Misses       1129     1116      -13     
  Partials      193      193              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarpele dkarpele force-pushed the dk-GITOPS-7683 branch 5 times, most recently from fd30c7b to ee686a1 Compare October 27, 2025 17:57
Co-authored-by: Gemini AI <[email protected]>"
Signed-off-by: Denis Karpelevich <[email protected]>
@dkarpele dkarpele marked this pull request as ready for review October 27, 2025 19:30
@dkarpele dkarpele self-assigned this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants