fix(wallet,profile,contracts): resolve issues #329, #343, #345, and #346 - #418
Merged
Merged
Conversation
arflexx#345, and arflexx#346 - Fix arflexx#329: Display available balance and add Max button in WithdrawModal with unit tests - Fix arflexx#343: Add confirmation phrase and 5s countdown modal to profile account deletion with Playwright e2e test - Fix arflexx#345: Add update_listing to Marketplace contract with seller authentication, Active status requirement, event emission, and unit tests - Fix arflexx#346: Implement emergency_withdraw in Escrow and Marketplace contracts with 72h timelock, paused checks, event emission, unit tests, and threat model documentation Closes arflexx#329, Closes arflexx#343, Closes arflexx#345, Closes arflexx#346
|
@GF-Hunter Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves four assigned issues across frontend and smart contracts:
Issue [frontend] - WithdrawModal does not display the user current balance requiring them to navigate away to check it #329:
[frontend] - WithdrawModal does not display the user current balance requiring them to navigate away to check itAvailable: ₦10,000.00) insideWithdrawModal.frontend/app/wallet/withdraw.test.tsxverifying available balance rendering and Max button input population.Issue [frontend] - Profile page account deletion does not require confirmation phrase risking accidental deletion #343:
[frontend] - Profile page account deletion does not require confirmation phrase risking accidental deletionfrontend/e2e/profile-delete.spec.tsasserting that the confirm button remains disabled until both the exact confirmation phrase is entered and the 5s timer expires.Issue [contract] - Marketplace create_listing does not support updating listing price or expiry after creation #345:
[contract] - Marketplace create_listing does not support updating listing price or expiry after creationupdate_listing(env, seller, listing_id, new_price, new_expires_at)onMarketplaceContract.seller.require_auth()) and checkedlisting.seller == seller.Activestatus.updatedevent (topics: ["updated"],data: (listing_id, seller, new_price, new_expires_at)).Issue [contract] - Neither contract has an emergency withdrawal function for trapped funds in event of a critical bug #346:
[contract] - Neither contract has an emergency withdrawal function for trapped funds in event of a critical bugemergency_withdraw(env, token, recipient, amount)to both Escrow and Marketplace contracts.admin.require_auth()) and required contract to be inPausedstate.EMERGENCY_TIMELOCK_SECS = 259_200) betweenpauseandemergency_withdrawto mitigate admin rug-pull risks.emergency_withdrawalevent.contracts/THREAT_MODEL.md.Related Issues