Skip to content

Fix/spinner accessibility 375 - #401

Merged
dark-sarge merged 3 commits into
arflexx:mainfrom
tobiadewola41-eng:fix/spinner-accessibility-375
Sep 27, 2026
Merged

dark-sarge merged 3 commits into
arflexx:mainfrom
tobiadewola41-eng:fix/spinner-accessibility-375

Conversation

@tobiadewola41-eng

Copy link
Copy Markdown
Contributor

closes #375

Summary

Closes #


Type of Change

  • feat — new feature
  • fix — bug fix
  • refactor — code change with no behaviour change
  • docs — documentation only
  • chore — build, deps, config
  • contract — Soroban smart contract change

What Changed.

File Change

How to Test

# example
cd server
npm run dev
curl http://localhost:3001/health

Checklist

General

  • Code compiles / builds without errors
  • No new TypeScript errors (tsc --noEmit)
  • Follows existing code style and patterns
  • No secrets, keys, or credentials committed
  • .env.example updated if new env vars were added

API changes

  • Request/response shapes documented in docs/api-reference.md
  • Zod validation added for all request inputs
  • Correct HTTP status codes returned
  • Auth middleware applied where required

Smart contract changes

  • require_auth() called on all state-changing functions
  • extend_ttl() called on all new persistent storage entries
  • Contract rebuilt with stellar contract build
  • Tested on testnet before merge
  • docs/smart-contract.md updated
  • New contract address added to server/.env.example if redeployed

Database changes

  • Migration script included
  • Indexes added for queried columns

Docs changes

  • Relevant doc in docs/ updated or created
  • README updated if structure or setup changed

Screenshots / Logs


Notes for Reviewer

@drips-wave

drips-wave Bot commented Sep 25, 2026

Copy link
Copy Markdown

@tobiadewola41-eng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@dark-sarge
dark-sarge merged commit 123e5d9 into arflexx:main Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[frontend] - Spinner component does not have an accessible label by default failing WCAG 1.3.1

2 participants