Issue 372 contract event topics - #385
Merged
dark-sarge merged 2 commits intoSep 25, 2026
Merged
Conversation
|
@Elizzy01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviews and documents the 9-byte ASCII limit on
symbol_short!event topics across the escrow and marketplace contracts. Borderline topics ("completed","cancelled") and the need forSymbol::new(&env, "...")for longer topics (>9 chars) are clearly documented, along with unit tests validating topic lengths and long topic handling.Closes #372
Type of Change
feat— new featurefix— bug fixrefactor— code change with no behaviour changedocs— documentation onlychore— build, deps, configcontract— Soroban smart contract changeWhat Changed.
contracts/escrow/src/lib.rssymbol_short!limit for event topic functions (noting"completed"and"cancelled"at 9 chars) and added test asserting topic lengths andSymbol::new(&env, ...)for longer topicscontracts/marketplace/src/lib.rssymbol_short!limit for event topic functions (noting"cancelled"at 9 chars) and added test asserting topic lengths andSymbol::new(&env, ...)for longer topicsHow to Test
Run contract test suites:
cargo test --manifest-path contracts/Cargo.tomlChecklist
General
.env.exampleupdated if new env vars were addedAPI changes
docs/api-reference.mdSmart contract changes
require_auth()called on all state-changing functionsextend_ttl()called on all new persistent storage entriesdocs/smart-contract.mdupdatedserver/.env.exampleif redeployedDatabase changes
Docs changes
docs/updated or createdScreenshots / Logs
Notes for Reviewer
All topics using$\le 9$ characters. Any new topics exceeding 9 characters must use
symbol_short!are strictlySymbol::new(&env, "...").