-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added v2/floors/events #61
base: master
Are you sure you want to change the base?
Conversation
Eh, I'm not sure how much I like having the same data accessible via two endpoints (both
That's mostly there as an artifact of using the same code to handle multiple endpoints. Almost every endpoint is basically two functions -- one to load the list of all IDs, and another to load the details for a single ID. Those are passed into a function which handles all the pagination etc. in a uniform manner. I'd argue that the uniformity makes consumption easier (and it does make implementation easier, though the "frontend" component of the API servers is already the easiest bit to modify). |
As someone who just wrote a new API wrapper, yes it does! |
The Megaservers made |
That's a fairly good point. For some reason I thought that My original concern about duplicated data is thus moot. |
I still think a v2 for events would be nice. The primary reasons for this would be:
Rather than implement the maps via "v2/floors" or "v2/continents", personally I'd prefer the v2 events endpoint to take the map id instead, so I would advocate "v2/maps/events". I've pasted a bit of javascript below that converts the current output of v1/event_details to a format I'd like.
|
So i'd like to merge the static data from former /v1/event_details.json into a maps response as per this forum thread: https://forum-en.guildwars2.com/forum/community/api/API-Suggestion-Event-Details/2354712
Also, this: #2 (comment)