ADCM-6076 Add unit tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sealwing
requested review from
DanBalalan,
Starovoitov and
a-alferov
as code owners
Starovoitov
reviewed
Nov 18, 2024
| assert all(map(check_entry, result)) | ||
| assert len(requester.queue) == len(response_sequence) - 1 | ||
|
|
||
| # all |
There was a problem hiding this comment.
maybe to split it by pytest parametrization into subtests?
There was a problem hiding this comment.
subtests (as in unittest) isn't naturally supported in pytest
but if you mean splitting by method -- checks aren't the same for all of them (some require extra checks)
if you mean making parametrized test instead of _test* -- it's a good idea, but in this particular case I see only "magical" implementation of it (since it's convenient to bond some values before the _test* call)
DanBalalan
approved these changes
Nov 18, 2024
a-alferov
approved these changes
Nov 18, 2024
a-alferov
pushed a commit
that referenced
this pull request
Dec 9, 2024
Starovoitov
pushed a commit
that referenced
this pull request
Dec 13, 2024
Starovoitov
pushed a commit
that referenced
this pull request
Dec 16, 2024
Starovoitov
pushed a commit
that referenced
this pull request
Dec 16, 2024
a-alferov
pushed a commit
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.