Skip to content

fix: Add error detection function and test for ZeroDivisionError and other errors alike #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sitabulaixizawaluduo merged 4 commits into from
May 13, 2026
+29 −3
Merged

fix: Add error detection function and test for ZeroDivisionError and other errors alike #1332

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89e19c8
test: add test for ZeroDivisionError
chenzhiyi021 May 11, 2026
5842652
fix: add error detection in PythonTool's execute method
chenzhiyi021 May 11, 2026
f3da540
fix: fix pre-commit format
chenzhiyi021 May 12, 2026
2adbb83
Merge branch 'main' into tir-exp
chenzhiyi021 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions areal/experimental/openai/proxy/proxy_rollout_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,7 @@ def _setup_openai_client():
# any attacker who can reach this port can call admin endpoints
# (grant_capacity, start_session, export_trajectories, ...).
loopback_hosts = {"127.0.0.1", "::1", "localhost"}
allow_override = (
os.environ.get("AREAL_ALLOW_DEFAULT_ADMIN_KEY", "0") == "1"
)
allow_override = os.environ.get("AREAL_ALLOW_DEFAULT_ADMIN_KEY", "0") == "1"
if _server_host in loopback_hosts or allow_override:
logger.warning(
"Using default admin API key. Change 'admin_api_key' in "
Expand Down
21 changes: 21 additions & 0 deletions examples/tir/tests/test_tir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,27 @@ async def test_tool_manager():
await calc_manager.acleanup()


@pytest.mark.asyncio
async def test_tool_manager_error_handling():
"""Test tool manager error handling with real execution"""
python_manager = ToolManager(timeout=10, enabled_tools="python", debug_mode=False)

try:
# Test ZeroDivisionError
zero_result, zero_status = await python_manager.aexecute_tool_call(
"```python\n1 / 0\n```"
)
print(f"Zero division result: {zero_result}, status: {zero_status}")
assert zero_status == ToolCallStatus.ERROR
assert (
"division by zero" in zero_result.lower()
or "zerodivisionerror" in zero_result.lower()
)

finally:
await python_manager.acleanup()


@pytest.mark.asyncio
async def test_tir_workflow():
"""Test TIR workflow initialization."""
Expand Down
11 changes: 8 additions & 3 deletions examples/tir/tools/python_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,14 @@ def execute(self, parameters: dict[str, Any]) -> tuple[str, ToolCallStatus]:

try:
# Directly call apply to avoid using ProcessPool in async environment
result = self.python_executor.apply(code)
logger.debug(f"Python execution completed: {str(result)[:100]}...")
return str(result), ToolCallStatus.SUCCESS
res, report = self.python_executor.apply(code)

if report != "Done":
logger.error(f"Error in Python execution: {report}")
return f"Error: {report}", ToolCallStatus.ERROR

logger.debug(f"Python execution completed: {str(res)[:100]}...")
return str(res), ToolCallStatus.SUCCESS
except Exception as e:
logger.error(f"Python execution error: {e}")
return f"Error: {str(e)}", ToolCallStatus.ERROR
Loading