Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Non-translated media fields display as empty #2525

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

zeezo887
Copy link
Collaborator

@zeezo887 zeezo887 commented Mar 6, 2024

Description

This PR adds a new form field property disableTranslate() to force the field to disable translation when twill.media_library.translated_form_fields is set to true.

Usage:

FormBuilder

Medias::make()
    ->name('cover')
    ->label('Cover image')
    ->disableTranslate()
    ->max(5)

Directive

@formField('medias', [
    'name' => 'cover',
    'label' => 'Cover image',
    'note' => 'Also used in listings',
    'fieldNote' => 'Minimum image width: 1500px',
    'disableTranslate' => true
])

FormView

<x-twill::medias
    name="cover"
    label="Cover image"
    note="Also used in listings"
    field-note="Minimum image width: 1500px"
    disable-translate
/>

Related Issues

Fixes #483

Copy link
Member

@ifox ifox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working as expected, let's discuss and revisit.

@ordigital
Copy link
Contributor

This is not a adequate solution. Translation of media fields should work in the same way as in other types of fields, so just by using ->translatable(). Translations should not be globally enabled by default, and there should not be a requirement to disable it in every field of an existing project, when a developer decides to add one translatable media field somewhere. No one would want this behavior in text fields, so why would anyone want this in media fields?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-translated media fields display as empty
3 participants