Add type declaration to helpers #2512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just starting the process of adding type declarations, started with the helpers because it's the ones we can do in v3 without any breaking changes (because passing any type differently would already result in fatal errors)
Also added some small perf improvement by using ->all() instead of ->toArray() (the latter being more expensive because of a map) or completely keeping them as collections which are iterable, there will be more to come, but just a few obvious one
I also added real deprecation messages to deprecated helpers
I also replaced the namespace of larastan which has moved to https://github.com/larastan/larastan (the old one is abandonned)
Not in this PR, but I'd also like to eventually deprecate all helper methods except really vital ones (like twillTrans) and move them to namespaced helper classes with facade instead to avoid polluting the global namespace