Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace phpcs with laravel/pint #2499

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Feb 26, 2024

Now that pint is the standard for laravel project, it would be nice to switch to it, it uses phpcs under the hood but with an extensive set of rules

It really homogenizes the code and removes all the unused imports/variables

I added cghooks so that any code committed (with the project installed with composer) will automatically get pinted while committing

I'm aware that's a big diff and I can resubmit it without the diff if you prefer to apply it separatly (but tests will fail)

I also suggest to merge a maximum of PR first and I can rebase this PR to avoid conflicts with existing PRs

@Tofandel Tofandel changed the title Replace phpcs with pint Replace phpcs with laravel/pint Feb 26, 2024
@Tofandel Tofandel force-pushed the replace-phpcs-with-pint branch 2 times, most recently from 636827b to 2d1ccc9 Compare February 26, 2024 19:37
@Tofandel Tofandel force-pushed the replace-phpcs-with-pint branch from 2d1ccc9 to 438c320 Compare February 26, 2024 21:26
@ifox
Copy link
Member

ifox commented May 24, 2024

I'm open to do this, thanks for suggesting it. I will ping you when it is ready to rebase.

@ifox ifox added this to the Twill 4.0 milestone Jun 4, 2024
@ifox ifox added the type: enhancement New feature or request label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants