[2.x] Feature: Allow displaying the date of an uploaded file #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifox
reviewed
Mar 27, 2023
ifox
reviewed
Mar 27, 2023
ifox
reviewed
Mar 27, 2023
PR Summary
|
ifox
changed the title
Tofandel
reviewed
Jan 10, 2024
src/Models/File.php
Outdated
| @@ -43,7 +43,9 @@ public function toCmsArray() | |||
| 'original' => FileService::getUrl($this->uuid), | |||
| 'size' => $this->size, | |||
| 'filesizeInMb' => number_format($this->attributes['size'] / 1048576, 2), | |||
| ]; | |||
| ] + (config('twill.file-library.show_uploaded_date') | |||
| ? ['uploadedDate' => $this->created_at->format("d/m/Y H:i")] | |||
There was a problem hiding this comment.
Seems this is not using the newly added option twill.file-library.format_uploaded_date
There was a problem hiding this comment.
On which branch (v2, v3)do you me to PR this update?
There was a problem hiding this comment.
@gilbo75 do you need this feature on a Twill 2 project? If you do, please address the issue mentioned by Tofandel and I can merge and release a new minor on Twill 2.
There was a problem hiding this comment.
Hello,
Yes, I need this feature on Twill 2
gilbo75
commented
Jan 18, 2024
|
Hello,
yes, I need this feature on Twill 2
…On Wed, Jun 5, 2024 at 1:55 AM Quentin Renard ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Models/File.php
<#2173 (comment)>:
> @@ -43,7 +43,9 @@ public function toCmsArray()
'original' => FileService::getUrl($this->uuid),
'size' => $this->size,
'filesizeInMb' => number_format($this->attributes['size'] / 1048576, 2),
- ];
+ ] + (config('twill.file-library.show_uploaded_date')
+ ? ['uploadedDate' => $this->created_at->format("d/m/Y H:i")]
@gilbo75 <https://github.com/gilbo75> do you need this feature on a Twill
2 project? If you do, please address the issue mentioned by Tofandel and I
can merge and release a new minor on Twill 2.
—
Reply to this email directly, view it on GitHub
<#2173 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJXVNP242O6OD2WYXQL6EZLZFZHWRAVCNFSM6AAAAAAVTYTJKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJXGU4TQNRXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Tofandel
reviewed
Jun 5, 2024
|
@gilbo75 Why did you close the PR instead of just committing the suggested change? |
Co-authored-by: Adrien Foulon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows displaying the date of an uploaded file in the file library.
This option is manageable with a Twill variable.