-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Set position on multi selects #2167
Open
antonioribeiro
wants to merge
3
commits into
area17:2.x
Choose a base branch
from
antonioribeiro:set-position-on-multi-selects
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[2.x] Set position on multi selects #2167
antonioribeiro
wants to merge
3
commits into
area17:2.x
from
antonioribeiro:set-position-on-multi-selects
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ifox
changed the title
Set position on multi selects
[2.x] Set position on multi selects
Mar 29, 2023
haringsrob
added a commit
that referenced
this pull request
Mar 30, 2023
ifox
added a commit
that referenced
this pull request
Feb 4, 2024
* #2167: Keep in mind order of multiselect. * cleanup. * Remove node-forge and update dependencies * Update default compiled assets --------- Co-authored-by: Quentin Renard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a model with a bunch of different tags:
That are using multi-selects
One of our frontend pages needs to use the first tag of each of these fields. So I I tried to get the ordered:
Just find that the position field is not being filled up, they are all
null
, so this PR is intended to do it automatically, unless there's already a position being set by the application.Related Issues