[2.x] Support Chinese slug #1907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thingasd
changed the title
|
Holding this one back for testing with #1897 |
|
Hey @thingasd Could you tell me what is expect to be the slug for when I for example enter:
Kind regards, |
test-知道 |
|
ok, so slugs can actually contain chinese characters? |
This pr allows slugs to contain Chinese characters, which can be used in the URL for improving the readability. i.e. http://www.example.com/例子 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the slugify function to accept Chinese character as slug, it should work with setting appropriate config twill.slug_utf8_languages