-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] allow tagged table to be used with other tables than tag table #1723
base: 2.x
Are you sure you want to change the base?
[3.x] allow tagged table to be used with other tables than tag table #1723
Conversation
Hey @YasienDwieb, I am not too sure about this one. This feels like something that is more for the "related" table? So you could add a "tags" which is a browser field and unify that? |
Hey @YasienDwieb, I had another brief look at this. It is missing a migration to make it available on existing sites. Also, we needs to have a bit of doc's on this, but I feel since this is a new feature it should go straight into Twill 3. |
aea8372
to
b101999
Compare
Hey @haringsrob , Also, yeah, it would need some docs, I will work on that too. Thank you |
Hey @YasienDwieb, That migration works fine for new Twill installations, however, for an existing Twill installation that will not work. So the changes you made to the table should move to a new migration file instead. |
This will go into 3.x only, I will work on the update. |
Description
For situations where you can create tags based on existing models other than the tag table, you will have to create pivot table for doing that. Taking into consideration that you can make this tagging relation with more than one model, therefore you will have to do more and more similar tables just to acheive that tagging functionality
For example: In case you using 5 models as tags, you will create 5 more tables and if this tagging will be needed for other models, hence it will produce a lot of tables
I think using the same Tagged table for doing this could be a good option.
Related Issues