Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Remove 'with' from orderByTranslation scopes #1493

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

domihagen
Copy link
Contributor

Description

When using the scope function withActiveTranslations() in combination with orderByTranslation() or orderByRawByTranslation, the orderBy functions was overwriting the with-query from withActiveTranslations(). This results in all languages being delivered instead of just the current one.

@haringsrob haringsrob changed the title Remove 'with' from orderByTranslation scopes [2.x] Remove 'with' from orderByTranslation scopes Jul 8, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Dominik Hagen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants