Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x][POC] 1305 unsaved changes indicator #1378

Draft
wants to merge 3 commits into
base: 3.x
Choose a base branch
from

Conversation

haringsrob
Copy link
Contributor

Description

This is just splitting the indicator from #1359

@haringsrob haringsrob added the status: waiting for design input This PR or issue needs design input or review label Jan 14, 2022
@haringsrob haringsrob added this to the 3.x initial release milestone Apr 26, 2022
@haringsrob haringsrob changed the base branch from 2.x to 3.x July 8, 2022 10:43
@haringsrob haringsrob changed the title 1305 unsaved changes indicator [3.x][POC] 1305 unsaved changes indicator Jul 8, 2022
@kylegoines
Copy link
Contributor

The new UX implementation probably will require a bit of rework.
The new design uses a custom UI alert when leaving "unsaved changes"

heres the new UX/UI for the alert:

Screen Shot 2022-11-17 at 1 08 36 PM

currently the alert is being triggered via beforeunload but this wont work for a custom alert. I believe their will need a refactor of all links and buttons to watch for change state of state.publication.hasUnsavedChanges

@ifox ifox marked this pull request as draft March 29, 2023 12:49
@ifox ifox removed this from the 3.x initial release milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for design input This PR or issue needs design input or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants