Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate electron params in second instance startup #2686

Merged
merged 1 commit into from
Apr 5, 2025

Conversation

giacomocusinato
Copy link
Collaborator

Motivation

Resolved #2678

Change description

Propagate argv electron params when starting a second instance

@giacomocusinato giacomocusinato added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Apr 4, 2025
@giacomocusinato giacomocusinato marked this pull request as draft April 4, 2025 13:52
@davegarthsimpson davegarthsimpson self-requested a review April 4, 2025 14:00
@giacomocusinato giacomocusinato force-pushed the fix-second-instance-argv branch from b87b545 to e62764b Compare April 4, 2025 14:03
@giacomocusinato giacomocusinato marked this pull request as ready for review April 4, 2025 14:04
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #2678.

Thanks Giacomo!

@giacomocusinato giacomocusinato merged commit 56ab874 into main Apr 5, 2025
36 checks passed
@giacomocusinato giacomocusinato deleted the fix-second-instance-argv branch April 5, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
3 participants