Skip to content

ARM 64 Runners #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
- 'static/**'
- '*.md'
tags:
- '[0-9]+.[0-9]+.[0-9]+*'
- '[0-9]+.[0-9]+.[0-9]+*'
workflow_dispatch:
inputs:
paid-runners:
Expand Down Expand Up @@ -133,6 +133,18 @@ env:
name: macOS_arm64_dmg
- path: '*macOS_arm64.zip'
name: macOS_arm64_zip
- config:
name: ARM Ubuntu 22.04
runs-on: ubuntu-22.04-arm
container: |
null
job-transfer-artifact-suffix: ARM_64bit
mergeable-channel-file: 'true'
artifacts:
- path: '*Linux_arm64.zip'
name: Linux_arm64_zip
- path: '*Linux_arm64.AppImage'
name: Linux_arm64_app_image
PAID_RUNNER_BUILD_DATA: |
# This system was implemented to allow selective use of paid GitHub-hosted runners, due to the Apple Silicon runner
# incurring a charge at that time. Free Apple Silicon runners are now available so the configuration was moved to
Expand Down Expand Up @@ -290,7 +302,7 @@ jobs:
# to skip passing signing credentials to electron-builder
IS_WINDOWS_CONFIG: ${{ matrix.config.name == 'Windows' }}
INSTALLER_CERT_WINDOWS_CER: "/tmp/cert.cer"
# We are hardcoding the path for signtool because is not present on the windows PATH env var by default.
# We are hardcoding the path for signtool because it is not present on the Windows PATH env var by default.
# Keep in mind that this path could change when upgrading to a new runner version
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe"
WIN_CERT_PASSWORD: ${{ secrets[matrix.config.certificate-password-secret] }}
Expand All @@ -310,6 +322,10 @@ jobs:
timeout-minutes: 90

steps:
- name: Install Chromium (ARM only)
if: matrix.config.name == 'ARM Ubuntu 22.04'
run: sudo apt-get update && sudo apt-get install -y chromium-browser

- name: Symlink custom working directory
shell: cmd
if: runner.os == 'Windows' && matrix.config.working-directory
Expand All @@ -319,7 +335,6 @@ jobs:
- name: Checkout
uses: actions/checkout@v4


- name: Install Node.js
if: runner.name != 'WINDOWS-SIGN-PC'
uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion arduino-ide-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"reporter": "spec",
"colors": true,
"watch-extensions": "js",
"timeout": 10000
"timeout": 20000
},
"files": [
"lib",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ describe('boards-service-impl', () => {

describe('search', () => {
it('should run search', async function () {
this.timeout(20_000);
const result = await boardService.search({});
expect(result).is.not.empty;
});
Expand Down
2 changes: 1 addition & 1 deletion arduino-ide-extension/src/test/node/node-test-bindings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ export async function startDaemon(
configService.onStart();
daemon.onStart();
await Promise.all([
waitForEvent(daemon.onDaemonStarted, 10_000),
waitForEvent(daemon.onDaemonStarted, 20_000),
coreClientProvider.client,
]);
if (startCustomizations) {
Expand Down
Loading