WifiS3 - Non blocking Wifi connect #461
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… timeout value for buf_read in modem. Fix bug where timout is reset to the default of 10000ms when calling begin
…ng for connection to wifi
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents non blocking connection to wifi, so that normal loop processing can continue whilst waiting for the connection to be established.
Also a potential bug fix in Modem.cpp where MODEM_TIMEOUT was used during begin, effectively ignoring what a user may have set the value to.
Appreciate it's a long shot this getting through, but happy to make adjustments if required.