Added read functions to the LiquidCrystal library #1517
Conversation
Added functions to read data from LCD, to delete last character, to delete a character at specified position, get current position, get character from a position and get more characters at once, making it faster.
|
If there are any problems please tell me. I really want to know why it dose not get merged, with all my respect I appreciate your decision. Thank you for the time! |
|
Can I build this pull request? |
|
If you ask for my permission or something like that, then sure you can. If you ask in order to know that it works correctly, I can say that it was tested on my Uno before making the pull request. |
|
@Chisalita sorry for the comment from arduinobot. we are setting up automated build of all PRs, so that we can provide a downloadable version of the patched IDE |
|
👍 thanks for this! |
|
I just noticed this PR. I like what it does, so I did a course review of the code. I've added some inline comments in the commit about things I think need to be changed. Overall, I think that the new functions added do not fit in the style of the other Arduino APIs completely and need some improvement. Also, you've removed a lot of trailing spaces (your editor probably did that) which are completely unrelated to the commit at hand and thus complicate review. I'm all for removing trailing whitespace, but you should do it in a separate commit then (which only changes whitespace). Alternatively, configure your editor to leave the whitespace alone. In either case, please update this pullrequest to remove the whitespace changes from the main commit (note that you can (force-)push to your branch to update this pullrequest). |
Modified the commit in which I added reading functions, I used the suggestions from the comments to make it fit in the API style and improved the code a little
cmaglie
added
feature request
|
This issue was moved to arduino-libraries/LiquidCrystal#7 |
|
Sorry closed by mistake |
|
Moved to arduino-libraries/LiquidCrystal#15 |
Added functions to read data from LCD, to delete last character, to
delete a character at specified position, get current position, get
character from a position and get more characters at once, making it
faster.