-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] #24
base: master
Are you sure you want to change the base?
[Documentation] #24
Conversation
Signed-off-by: Agha Saad Fraz <[email protected]>
Signed-off-by: Agha Saad Fraz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AghaSaad04,
First off, thanks for taking the time to submit this pull request!
I've made some comments, I think the best way to move forward is to decide as a team why this content needs to be in the read me vs being on the arduino.cc website with a link from the read me.
These comments probably also apply to: arduino-libraries/SigFox#19
@dcuartielles @cmaglie @facchinm @lxrobotics @agdl @SimonePDA @per1234 please review and let us know your thoughts.
|
Signed-off-by: Agha Saad Fraz [email protected]
I have to document this library while working as a technical writer for Arduino in GSoD. I have documented the Liquid Crystal library as per David Cuartielles' plan.
I have done the following steps
Followed writing standards
Added Description
Added Installation steps
Added Features
Added functions
Added example
Added contributing heading and its file
Added credits
Referenced external resources