-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented non blocking ota download for unor4 #468
Implemented non blocking ota download for unor4 #468
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 33 33
Lines 1520 1521 +1
=======================================
+ Hits 1450 1451 +1
Misses 70 70 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
c965282
to
7e17b23
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7e17b23
to
78821db
Compare
Memory usage change @ 78821db
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where OTA_UPDATE_VERSION is defined?
I don't remember, It made sense when I wrote the PR, I will just remove those preprocessor directives |
78821db
to
3e6fe5a
Compare
Memory usage change @ 3e6fe5a
Click for full report table
Click for full report CSV
|
Memory usage change @ 7ba5c37
Click for full report table
Click for full report CSV
|
Implemented non blocking OTA download, if the fw of the board supports it.
This requires the latest (yet to be released) wifi module fw: arduino/ArduinoCore-renesas#325,
Ota fallbacks to blocking download if the fw doesn't support it.