-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ArduinoBearSSL library #465
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 31 31
Lines 1370 1370
=======================================
Hits 1299 1299
Misses 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e1f4f19
to
74de9b6
Compare
e1f4f19
to
351f84c
Compare
e1f4f19
to
73e4565
Compare
Memory usage change @ 73e4565
Click for full report table
Click for full report CSV
|
… ArduinoIoTCloud to ArduinoBearSSL library - remove unnecessary include - rename - add include guards - move into tls folder
…library configuration
Memory usage change @ 78bff5d
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this marked as moved? they seem a complete different file to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is a complete different file 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add ArduinoBearSSL also in the library.properties file as a dependency
Memory usage change @ b1fa82b
Click for full report table
Click for full report CSV
|
Needs arduino-libraries/ArduinoBearSSL#80 in order to configure custom client profile and reduce build size.
Fixes: #398