Reduce public API by turning connect/disconnect into protected methods. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successfully tested on PROD with
|
…no need to access those functions from the outside. It might be relevant to add a 'end' function which does the opposite of the 'begin' function, that is ramping everything down in an orderly fashion
…ion can't fail anyway
aentinger
force-pushed
the
reduce-lora-api
branch
from
d6438e5 to
3142ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public
ArduinoIoTCloudmember methodsconnectanddisconnectshould not be called by the user of the library (they are called internally) and are therefore transformed toprotectedmember functions. In the future aendfunction should be added (see #73) which works the opposite way to the thebeginmethod and cleans everything up.