Repository navigation
feat: unify request/response header and body access - #81
Merged
Merged
Conversation
…headers Remove Header, SetHeader, and SetRequestHeader from Context. Header manipulation now lives solely in c.Request().Header and c.Response().Header with standard net/http verbs. Add Response() live view backed by the recording writer so response reads no longer need status-gated workarounds. Migrate examples, e2e filters, and docs.
Document stale-view loss across next and read-only non-Header fields. Guard nil request Header in newHandlerContext, nil writer in Status, and empty StatusText in Response status line. Cover with fresh-view, nil-map, status-format, and nil-body tests.
Signed-off-by: Ardika Bagus <me@ardikabs.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 66.15% 66.43% +0.28%
==========================================
Files 27 27
Lines 1743 1764 +21
==========================================
+ Hits 1153 1172 +19
- Misses 491 492 +1
- Partials 99 100 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.