Flush the file after each auto log line, to prevent partial lines on disk - #1
Open
angusholder wants to merge 1 commit into
Open
Flush the file after each auto log line, to prevent partial lines on disk#1angusholder wants to merge 1 commit into
angusholder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your work on this, it works great. Big improvement over the program ZKETech supplies!
We have a scraper script that reads the CSVs periodically while the EBC is running, and I noticed that often the file ends with an incomplete line. I believe that WriteLn is buffering by number of bytes rather than by line, so sometimes it ends up flushing half way through writing a line. I fixed it by flushing after each SaveCSVLine in auto log mode.