fix(grpc): Update GrpcLoaderHelper to use rootId for root json naming #8201
+85
−78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the logic of the getDescriptorSets method of the GrpcLoaderHelper class.
Previously, if the Protobuf Root did not have a name, it utilized an index to determine the name. This could cause the GrpcTransportHelper to select the wrong grpcRootJson directory when there was more than one gRPC Subgraph with an unnamed Protobuf Root.
So I put a variable called rootId in the module with the GrpcLoaderHelper class, and changed it to use that variable to determine the name instead of the index.
Related #7962
Type of change
Screenshots/Sandbox (if appropriate/relevant):
N/A
How Has This Been Tested?
I have confirmed that the issue is fixed with a patch in the issue reproduction branch that reflects the changes in this pull request.
As mentioned in #7962 (comment), To fix the issue, it needs to be changed to allow passing directives when calling mergeDirectives.
Checklist:
CONTRIBUTING doc and the
style guidelines of this project
changeset using
yarn changeset
that bumps the versionFurther comments
N/A