Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(json-schema): make array elements nonnullable (#6630) #6633

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(json-schema): make array elements nonnullable (#6630) #6633

wants to merge 2 commits into from

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Mar 6, 2024 •
edited
Loading

Related #6621

@ardatan @github-actions
fix(json-schema): make array elements nonnullable (#6630)
0db820c 
* fix(json-schema): make array elements nonnullable

* Changeset

* chore(dependencies): updated changesets for modified dependencies

* Fix build

* Remove extra yarn.lock

* chore(dependencies): updated changesets for modified dependencies

* Fix integration tests

* Update more snapshots

* Snapshots last turn

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codesandbox CodeSandbox
Copy link

codesandbox bot commented Mar 6, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

💻 Website Preview

The latest changes are available as preview in: https://790a435e.graphql-mesh.pages.dev

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-mesh/cache-cfw-kv 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/cache-file 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/cache-localforage 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/cache-redis 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/compose-cli 0.2.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/fusion-composition 0.0.2-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/fusion-runtime 0.2.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/apollo-link 0.98.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/cli 0.89.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/config 0.99.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/graphql 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/grpc 0.98.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/json-schema 0.99.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/mongoose 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/mysql 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/neo4j 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/odata 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/openapi 0.99.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/postgraphile 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/raml 0.99.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/soap 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/supergraph 0.2.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/thrift 0.98.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/tuql 0.98.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/http 0.98.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/merger-bare 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/merger-federation 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/merger-stitching 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/runtime 0.98.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/store 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-cache 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-encapsulate 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-extend 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-federation 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-filter-schema 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-hive 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-hoist-field 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-naming-convention 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-prefix 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-prune 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-rate-limit 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-rename 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-replace-field 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-resolvers-composition 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-transfer-schema 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transform-type-merging 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/types 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/urql-exchange 0.98.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/utils 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@omnigraph/json-schema 0.99.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@omnigraph/mysql 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@omnigraph/neo4j 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@omnigraph/openapi 0.99.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@omnigraph/raml 0.99.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@omnigraph/soap 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@omnigraph/sqlite 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@omnigraph/thrift 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-deduplicate-request 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-hive 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-http-cache 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-http-details-extensions 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-live-query 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-mock 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-newrelic 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-operation-field-permissions 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-operation-headers 0.0.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-prometheus 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-rate-limit 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-response-cache 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-snapshot 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-statsd 0.97.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/serve-cli 0.3.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/serve-runtime 0.2.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-common 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-http 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-mysql 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-neo4j 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-rest 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-soap 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-sqlite 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-thrift 0.1.1-alpha-20240306103519-2d32e757c5b57b02c4cc86c9d11b43714f531e04 npm ↗︎ unpkg ↗︎

@herman-gg
Copy link

Good day, @ardatan, do you think these changes will get to one of the release version anytime soon? I noticed that latest [email protected] still uses old approach and generates arrays with nullable elements ([Item] instead of [Item!])

@ardatan
Copy link
Owner Author

ardatan commented Jul 1, 2024

generates arrays with nullable elements ([Item] instead of [Item!])

Because this PR has not merged and released yet.
This PR is not our priority now because there are more important things in our roadmap currently.
We cannot merge and release this PR directly because we should test nullable arrays etc.

@ardatan ardatan force-pushed the master branch 4 times, most recently from 72ed5cd to fbf068b Compare July 24, 2024 12:25
@ardatan ardatan force-pushed the master branch 2 times, most recently from b78fdb4 to a1bfc49 Compare August 2, 2024 15:13
@ardatan ardatan force-pushed the master branch 2 times, most recently from f6b9ba0 to 4d52840 Compare September 11, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
omnigraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ardatan @herman-gg