Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested resolver bug replication #5433

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dr3
Copy link
Contributor

@dr3 dr3 commented May 16, 2023

Description

Replication case, resolver inside an additionalResolvers only receives __typename, and no data from the response

context.Swapi.Query.pet_by_petId returns
image

When the upstream server returns { "id": "0fc9111f-570d-4ebe-a72e-ff4eb274bc65", }

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2023

⚠️ No Changeset found

Latest commit: d8edebb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ardatan
Copy link
Owner

ardatan commented May 17, 2023

In additional resolvers, returned type should match the type of the field of the resolver. Otherwise, selectionSet should be given.

@ardatan ardatan force-pushed the master branch 4 times, most recently from 72ed5cd to fbf068b Compare July 24, 2024 12:25
@ardatan ardatan force-pushed the master branch 2 times, most recently from b78fdb4 to a1bfc49 Compare August 2, 2024 15:13
@ardatan ardatan force-pushed the master branch 2 times, most recently from f6b9ba0 to 4d52840 Compare September 11, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants